Skip to content

index_build: Set default binary_args. #13559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

index_build: Set default binary_args. #13559

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions infra/base-images/base-builder/indexer/index_build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,8 +652,11 @@ def main():
logging.warning('--target-args is deprecated, use --target-arg instead.')
target_args = shlex.split(args.target_args)
else:
logging.info('No target args specified.')
target_args = []
target_args = [manifest_types.INPUT_FILE]
logging.info(
'No target args specified. Defaulting to %s.', repr(target_args)
)

if args.target_env:
target_env = manifest_types.parse_env(args.target_env)
else:
Expand Down
4 changes: 4 additions & 0 deletions infra/base-images/base-builder/indexer/index_build_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,10 @@ def _check_archive(self, archive_path: pathlib.Path):
self.assertIsNotNone(
tar.getmember('obj/' + manifest['binary_config']['binary_name'])
)
self.assertCountEqual(
manifest['binary_config']['binary_args'],
['<input_file>']
)

self.assertTrue(has_obj_lib, 'obj/lib/ was not found in the archive.')
self.assertTrue(
Expand Down
Loading