tp: order tree rows for streaming folds - #7214
Draft
LalitMaganti wants to merge 1 commit into
Draft
Conversation
🎨 Perfetto UI Builds
|
LalitMaganti
changed the title
LalitMaganti
force-pushed
the
dev/lalitm/exec-tree-number-nodes
branch
from
August 25, 2026 14:59
a8cbdaa to
90f2c16
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-tree-order
branch
2 times, most recently
from
August 25, 2026 16:50
af2c641 to
de35bf5
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-tree-number-nodes
branch
from
August 26, 2026 16:44
1287f35 to
502083b
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-tree-order
branch
from
August 26, 2026 16:44
de35bf5 to
e416782
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-tree-number-nodes
branch
from
August 26, 2026 17:05
502083b to
3c03736
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-tree-order
branch
from
August 26, 2026 17:05
e416782 to
c443d73
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-tree-number-nodes
branch
from
August 26, 2026 17:13
3c03736 to
bef6e17
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-tree-order
branch
from
August 26, 2026 17:13
c443d73 to
dd4e893
Compare
Folding toward the root needs children before parents. Folding away from the root needs the opposite order. Neither order should be imposed on every source. TreeOrder takes the order known by the planner and produces the one requested by the fold. It passes matching input through, reverses the opposite order, and topologically sorts rows when no useful order is known. The operator reports an incorrect declared order, a parent missing from the input, or a cycle. It only stores rows when reordering requires it.
LalitMaganti
force-pushed
the
dev/lalitm/exec-tree-number-nodes
branch
from
August 26, 2026 17:39
bef6e17 to
ba601d3
Compare
LalitMaganti
force-pushed
the
dev/lalitm/exec-tree-order
branch
from
August 26, 2026 17:39
dd4e893 to
9546d09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Folding toward the root needs children before parents. Folding away from the
root needs the opposite order. Neither order should be imposed on every
source.
TreeOrder takes the order known by the planner and produces the one requested
by the fold. It passes matching input through, reverses the opposite order,
and topologically sorts rows when no useful order is known.
The operator reports an incorrect declared order, a parent missing from the
input, or a cycle. It only stores rows when reordering requires it.