tp: parse appended trace data without copying it - #7276
Draft
LalitMaganti wants to merge 1 commit into
Draft
Conversation
🎨 Perfetto UI Builds
|
Trace bytes arrive zero-copy into the tokenizer, and then Rpc::Parse
copies them straight back out because TraceProcessor needs to own what
it is given. For APPEND_TRACE_DATA that is a 32 MB memcpy per chunk,
which undoes the whole chain, on the wasm and httpd paths as much as
anywhere else.
Hand the parser the tokenizer's message instead: TraceBlob holds it for
as long as the bytes are needed, and the ring buffer moves onto another
buffer rather than recycling one still being read. Dispatching a message
now means handing over its bytes, so OnRpcMessage() takes an owned
message rather than a pointer and a length.
out/linux_clang_release/perfetto_integrationtests \
--gtest_filter='*Remote*:*Stdiod*:*ServerUnix*'
LalitMaganti
force-pushed
the
dev/lalitm/zerocopy-7-parse-no-copy
branch
from
August 28, 2026 15:11
3d2587d to
97857f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trace bytes arrive zero-copy into the tokenizer, and then Rpc::Parse
copies them straight back out because TraceProcessor needs to own what
it is given. For APPEND_TRACE_DATA that is a 32 MB memcpy per chunk,
which undoes the whole chain, on the wasm and httpd paths as much as
anywhere else.
Hand the parser the tokenizer's message instead: TraceBlob holds it for
as long as the bytes are needed, and the ring buffer moves onto another
buffer rather than recycling one still being read. Dispatching a message
now means handing over its bytes, so OnRpcMessage() takes an owned
message rather than a pointer and a length.
out/linux_clang_release/perfetto_integrationtests
--gtest_filter='Remote:Stdiod:ServerUnix'