Skip to content

Conversation

@benbowler
Copy link
Collaborator

@benbowler benbowler commented Nov 12, 2025

Summary

Addresses issue:

Relevant technical choices

Tests passed consistently on my fork.

The reason for the VRT changes is one common failure was the mobile variant of the All_Traffic_Widget GA4_Entity_Dashboard was a change in height due to how the chart rendered so I added a fixed height here.

PR Author Checklist

  • My code is tested and passes existing unit tests.
  • My code has an appropriate set of unit tests which all pass.
  • My code is backward-compatible with WordPress 5.2 and PHP 7.4.
  • My code follows the WordPress coding standards.
  • My code has proper inline documentation.
  • I have added a QA Brief on the issue linked above.
  • I have signed the Contributor License Agreement (see https://cla.developers.google.com/).

Do not alter or remove anything below. The following sections will be managed by moderators only.

Code Reviewer Checklist

  • Run the code.
  • Ensure the acceptance criteria are satisfied.
  • Reassess the implementation with the IB.
  • Ensure no unrelated changes are included.
  • Ensure CI checks pass.
  • Check Storybook where applicable.
  • Ensure there is a QA Brief.
  • Ensure there are no unexpected significant changes to file sizes.

Merge Reviewer Checklist

  • Ensure the PR has the correct target branch.
  • Double-check that the PR is okay to be merged.
  • Ensure the corresponding issue has a ZenHub release assigned.
  • Add a changelog message to the issue.

@github-actions
Copy link

Storybook is ready:

@github-actions
Copy link

github-actions bot commented Nov 12, 2025

Build files for 86d2a80 have been deleted.

@github-actions
Copy link

github-actions bot commented Nov 12, 2025

Size Change: 0 B

Total Size: 2.19 MB

ℹ️ View Unchanged
Filename Size
./dist/assets/blocks/reader-revenue-manager/block-editor-plugin/editor-styles.css 124 B
./dist/assets/blocks/reader-revenue-manager/block-editor-plugin/editor-styles.js 20 B
./dist/assets/blocks/reader-revenue-manager/block-editor-plugin/index.js 42.7 kB
./dist/assets/blocks/reader-revenue-manager/common/editor-styles.css 307 B
./dist/assets/blocks/reader-revenue-manager/common/editor-styles.js 20 B
./dist/assets/blocks/reader-revenue-manager/contribute-with-google/index.js 5.88 kB
./dist/assets/blocks/reader-revenue-manager/contribute-with-google/non-site-kit-user.js 5.07 kB
./dist/assets/blocks/reader-revenue-manager/subscribe-with-google/index.js 5.88 kB
./dist/assets/blocks/reader-revenue-manager/subscribe-with-google/non-site-kit-user.js 5.07 kB
./dist/assets/blocks/sign-in-with-google/editor-styles.css 84 B
./dist/assets/blocks/sign-in-with-google/editor-styles.js 20 B
./dist/assets/blocks/sign-in-with-google/index.js 18.6 kB
./dist/assets/css/googlesitekit-admin-css-********************.min.css 64.5 kB
./dist/assets/css/googlesitekit-adminbar-css-********************.min.css 11.7 kB
./dist/assets/css/googlesitekit-authorize-application-css-********************.min.css 846 B
./dist/assets/css/googlesitekit-wp-dashboard-css-********************.min.css 8.57 kB
./dist/assets/js/146-********************.js 963 B
./dist/assets/js/201-********************.js 2.85 kB
./dist/assets/js/314-********************.js 100 kB
./dist/assets/js/315-********************.js 3.08 kB
./dist/assets/js/379-********************.js 3.7 kB
./dist/assets/js/590-********************.js 1.89 kB
./dist/assets/js/640-********************.js 2.36 kB
./dist/assets/js/909-********************.js 1.01 kB
./dist/assets/js/analytics-advanced-tracking-********************.js 475 B
./dist/assets/js/googlesitekit-activation-********************.js 24.1 kB
./dist/assets/js/googlesitekit-ad-blocking-recovery-********************.js 54.9 kB
./dist/assets/js/googlesitekit-adminbar-********************.js 34.4 kB
./dist/assets/js/googlesitekit-api-********************.js 7.79 kB
./dist/assets/js/googlesitekit-block-tracking-********************.js 5.51 kB
./dist/assets/js/googlesitekit-components-********************.js 5.74 kB
./dist/assets/js/googlesitekit-consent-mode-********************.js 25.5 kB
./dist/assets/js/googlesitekit-data-********************.js 1.7 kB
./dist/assets/js/googlesitekit-datastore-forms-********************.js 6.99 kB
./dist/assets/js/googlesitekit-datastore-location-********************.js 1.51 kB
./dist/assets/js/googlesitekit-datastore-site-********************.js 17.3 kB
./dist/assets/js/googlesitekit-datastore-ui-********************.js 7.11 kB
./dist/assets/js/googlesitekit-datastore-user-********************.js 22.8 kB
./dist/assets/js/googlesitekit-entity-dashboard-********************.js 61.8 kB
./dist/assets/js/googlesitekit-events-provider-contact-form-7-********************.js 1.77 kB
./dist/assets/js/googlesitekit-events-provider-easy-digital-downloads-********************.js 745 B
./dist/assets/js/googlesitekit-events-provider-mailchimp-********************.js 1.77 kB
./dist/assets/js/googlesitekit-events-provider-ninja-forms-********************.js 1.69 kB
./dist/assets/js/googlesitekit-events-provider-optin-monster-********************.js 1.72 kB
./dist/assets/js/googlesitekit-events-provider-popup-maker-********************.js 1.79 kB
./dist/assets/js/googlesitekit-events-provider-woocommerce-********************.js 1.13 kB
./dist/assets/js/googlesitekit-events-provider-wpforms-********************.js 1.77 kB
./dist/assets/js/googlesitekit-i18n-********************.js 6.16 kB
./dist/assets/js/googlesitekit-key-metrics-setup-********************.js 46.5 kB
./dist/assets/js/googlesitekit-main-dashboard-********************.js 135 kB
./dist/assets/js/googlesitekit-metric-selection-********************.js 52.7 kB
./dist/assets/js/googlesitekit-modules-********************.js 19.9 kB
./dist/assets/js/googlesitekit-modules-ads-********************.js 47.6 kB
./dist/assets/js/googlesitekit-modules-adsense-********************.js 123 kB
./dist/assets/js/googlesitekit-modules-analytics-4-********************.js 187 kB
./dist/assets/js/googlesitekit-modules-pagespeed-insights-********************.js 23.5 kB
./dist/assets/js/googlesitekit-modules-reader-revenue-manager-********************.js 43.6 kB
./dist/assets/js/googlesitekit-modules-search-console-********************.js 65.3 kB
./dist/assets/js/googlesitekit-modules-sign-in-with-google-********************.js 34.4 kB
./dist/assets/js/googlesitekit-modules-tagmanager-********************.js 30 kB
./dist/assets/js/googlesitekit-notifications-********************.js 66.6 kB
./dist/assets/js/googlesitekit-polyfills-********************.js 230 B
./dist/assets/js/googlesitekit-settings-********************.js 124 kB
./dist/assets/js/googlesitekit-splash-********************.js 73.3 kB
./dist/assets/js/googlesitekit-user-input-********************.js 46 kB
./dist/assets/js/googlesitekit-vendor-********************.js 322 kB
./dist/assets/js/googlesitekit-widgets-********************.js 104 kB
./dist/assets/js/googlesitekit-wp-dashboard-********************.js 60 kB
./dist/assets/js/runtime-********************.js 1.93 kB

compressed-size-action

Copy link
Collaborator

@aaemnnosttv aaemnnosttv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the conflicts, thanks @benbowler !

@tofumatt tofumatt merged commit 8c023da into develop Nov 21, 2025
24 of 26 checks passed
@tofumatt tofumatt deleted the infrastructure/11534-unstable-vrts branch November 21, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants