Skip to content

[XLA] Remove dead argument in ProtoToHumanReadableJson #3350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[XLA] Remove dead argument in ProtoToHumanReadableJson #3350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions tsl/platform/human_readable_json.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,10 @@ namespace tsl {
//
// This string may not be strictly JSON-compliant, but it must be parsable by
// HumanReadableJSONToProto.
//
// When ignore_accuracy_loss = true, this function may ignore JavaScript
// accuracy loss with large integers.
absl::StatusOr<std::string> ProtoToHumanReadableJson(
const protobuf::Message& proto, bool ignore_accuracy_loss);
const protobuf::Message& proto);
absl::StatusOr<std::string> ProtoToHumanReadableJson(
const protobuf::MessageLite& proto, bool ignore_accuracy_loss);
const protobuf::MessageLite& proto);

// Converts a string produced by ProtoToHumanReadableJSON to a protobuf. Not
// guaranteed to work for general JSON.
Expand Down