[DSLX:TS] Check test functions are typed as () -> ()
#3062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdleary
force-pushed
the
cdleary/2025-09-12-check-test-fn-signature
branch
from
763bbfd to
d789085
Compare
cdleary
force-pushed
the
cdleary/2025-09-12-check-test-fn-signature
branch
from
d789085 to
fea0c17
Compare
| TypeInfo * type_info, | ||
| import_data->type_info_owner().GetRootTypeInfo(module.get())); | ||
|
|
||
| // Enforce `#[test]` function signature `() -> ()`. |
There was a problem hiding this comment.
In v2 it would probably make more sense to just add a HandleTestFunction in validate_concrete_type.cc with the logic you have here (starting from where you have the TestFunction ptr). Or perhaps a HandleFunction which does this if the parent is a TestFunction (not sure if the TestFunction itself gets a type).
There was a problem hiding this comment.
@richmckeever I tried that at first but it didn't kick in at the right times. I needed to implement it in both places, and then I deleted the Handle* and this one covered the other. I think maybe because it doesn't always need to concretize? It was kind of unclear to me why it wasn't kicking in for all the samples.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.