[Proc-scoped channels] Fix issues in get conversion records: Add a HandleInvocation method to get_conversion_records because otherwise it won't add imported functions to the list of functions to convert.
#3182
+91
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=80&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_817645758
branch
5 times, most recently
from
a7a4fdc to
2609033
Compare
…andleInvocation` method to `get_conversion_records` because otherwise it won't add imported functions to the list of functions to convert. Process child nodes of a function before adding the function to the list of conversion records, so that called functions (& procs) are added before the caller. Use the appropriate `type_info` based on the callee's module for all calls. PiperOrigin-RevId: 820253861
copybara-service
bot
force-pushed
the
test_817645758
branch
from
2609033 to
adf3798
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Proc-scoped channels] Fix issues in get conversion records: Add a
HandleInvocationmethod toget_conversion_recordsbecause otherwise it won't add imported functions to the list of functions to convert.Process child nodes of a function before adding the function to the list of conversion records, so that called functions (& procs) are added before the caller.
Use the appropriate
type_infobased on the callee's module for all calls.