Replace --emit_fail_as_assert flag with --emit_assert. #3191
+32
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_818806271
branch
5 times, most recently
from
9f3b11d to
c2b2a89
Compare
The name for this flag was quite bad as it implied that there may be some other cases where asserts could still be emitted. Instead change to the much more accurate "--emit_assert" flag to make clear that setting this to false causes **all** asserts to be suppressed. The ir_converter_main binary will emit a warning if this flag is passed (ignoring the value) and the standard bazel rules for XLS will automatically swap --emit_fail_as_assert to --emit_assert (and print a warning). PiperOrigin-RevId: 819958156
copybara-service
bot
force-pushed
the
test_818806271
branch
from
c2b2a89 to
d2feba1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace --emit_fail_as_assert flag with --emit_assert.
The name for this flag was quite bad as it implied that there may be some other cases where asserts could still be emitted. Instead change to the much more accurate "--emit_assert" flag to make clear that setting this to false causes all asserts to be suppressed.
The ir_converter_main binary will emit a warning if this flag is passed (ignoring the value) and the standard bazel rules for XLS will automatically swap --emit_fail_as_assert to --emit_assert (and print a warning).