-
Notifications
You must be signed in to change notification settings - Fork 2
Feat: Add tablestore longbow storage #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…/dagger into feat-add-tablestore-longbow-storage
if (LongbowStorageType.TABLESTORE.equals(LongbowStorageType.valueOf(configuration.getString(Constants.PROCESSOR_LONGBOW_STORAGE_TYPE)))) { | ||
return new LongbowStore(new TablestoreLongbowOperationStrategy(configuration)); | ||
} | ||
return new LongbowStore(new BigTableLongbowOperationStrategy(configuration)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
else if it BigTable then create line 36
else throw runtimeException with message, tablestore type not supported
this.data = new HashMap<>(); | ||
} | ||
|
||
public void addData(byte[] columnFamily, byte[] qualifier, byte[] value) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add unit test case for this method.
} | ||
|
||
@Override | ||
public ScanResult adapt(Row row) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add unit test for this
|
||
@Override | ||
public ScanResult adapt(Result result) { | ||
ScanResult scanResult = new ScanResult(result.getRow()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add unit test case for this
LongbowReadV2(LongbowKey.LONGBOW_READ, MandatoryFields.LONGBOW_READ, InvalidFields.LONGBOW_READ), | ||
LongbowWriteV2(LongbowKey.LONGBOW_WRITE, MandatoryFields.LONGBOW_WRITE, InvalidFields.LONGBOW_WRITE); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to remove these unused constants.
Introduce Tablestore as wide-column storage for longbow feature
Reference: https://www.alibabacloud.com/help/en/tablestore/developer-reference/quickly-use-the-tablestore-java-sdk?spm=a2c63.p38356.help-menu-27278.d_7_1_2.705a218fJtVlPx&scm=20140722.H_2591634._.OR_help-T_intl~en-V_1
Pending:
reference : https://github.com/ekawinataa/tablestore-demo/pulls