Skip to content

Conversation

ekawinataa
Copy link
Member

@ekawinataa ekawinataa commented Jul 30, 2025

if (LongbowStorageType.TABLESTORE.equals(LongbowStorageType.valueOf(configuration.getString(Constants.PROCESSOR_LONGBOW_STORAGE_TYPE)))) {
return new LongbowStore(new TablestoreLongbowOperationStrategy(configuration));
}
return new LongbowStore(new BigTableLongbowOperationStrategy(configuration));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

else if it BigTable then create line 36

else throw runtimeException with message, tablestore type not supported

this.data = new HashMap<>();
}

public void addData(byte[] columnFamily, byte[] qualifier, byte[] value) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add unit test case for this method.

}

@Override
public ScanResult adapt(Row row) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add unit test for this


@Override
public ScanResult adapt(Result result) {
ScanResult scanResult = new ScanResult(result.getRow());
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add unit test case for this

Comment on lines +14 to +15
LongbowReadV2(LongbowKey.LONGBOW_READ, MandatoryFields.LONGBOW_READ, InvalidFields.LONGBOW_READ),
LongbowWriteV2(LongbowKey.LONGBOW_WRITE, MandatoryFields.LONGBOW_WRITE, InvalidFields.LONGBOW_WRITE);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to remove these unused constants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants