feat: add autoscaling.external
#4388
Open
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replicas should not be rendered when external autoscaler like KEDA is used
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Currently there is no option to disable
replicasin Statefulset and Deployment controller type, when I use KEDA to autoscale alloy based on number of metrics that alloy cluster pulls. I triedreplicas: nullbut it also reset replica to 1 when upgrade helm. This could make some downtime (less than 30s).This PR is to add
autoscaling.externalvariable to removereplicaswhen external autoscaler is used.Which issue(s) this PR fixes
No issue exists.
Notes to the Reviewer
PR Checklist