pyroscope.java: allow custom asprof distributions instead of embeded one. #4452
+222
−182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Profiler(use Distribution).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExtractDistributionsfromasprof.Profilerasprof.Profileralltogether - after decoupling archive extraction logic, turns out it does nothing - useasprof.Distributioninstead everywhere.asprofdistribution - useful for cases when there is a fix for some problem upstream, but alloy has not been updated yet, so users could have a workaround without waiting for pyroscope to update the asprof within the alloy. Also useful for development - clone asprof, run make, point alloy to the build dir.This is for the next release, we should wait before RC is cut