[tempo-distributed] Add extraContainers parameter to tempo-distributed helm chart #3731
Conversation
Signed-off-by: Arun Cherla <[email protected]>
acherla
requested review from
a team,
BitProcessor,
Sheikh-Abubaker,
faustodavid,
mapno and
swartz-k
as code owners
|
|
Signed-off-by: Arun Cherla <[email protected]>
Signed-off-by: Arun Cherla <[email protected]>
acherla
changed the title
Signed-off-by: Arun Cherla <[email protected]>
Signed-off-by: Arun Cherla <[email protected]>
Signed-off-by: Arun Cherla <[email protected]>
Signed-off-by: Arun Cherla <[email protected]>
Signed-off-by: Arun Cherla <[email protected]>
|
@Sheikh-Abubaker any reason why this wasnt merged? Do i need to bump it to 141.2? |
Yes in order to fix the failed CI checks |
Signed-off-by: Arun Cherla <[email protected]>
Signed-off-by: Arun Cherla <[email protected]>
This was done upped from 1.142.1 to 2 |
| {{- with .Values.ingester.extraVolumes }} | ||
| {{- toYaml . | nindent 8 }} | ||
| {{- end }} | ||
| {{- with .Values.ingester.extraContainers }} |
There was a problem hiding this comment.
@acherla, You'd need to address some indentations, The extraContainers should be place within spec.containers.extraContainers. as of now it is placed within spec.extraContainers, imo it should be placed after this line here
Please address the same changes for the remaining templates below as well, ensuring extraContainers is placed within spec.containers.extraContainers instead of spec.extraContainers.
You could also validate if extraContainers are rendered in correct order by running helm template.
| {{- with .Values.querier.extraVolumeMounts }} | ||
| {{- toYaml . | nindent 12 }} | ||
| {{- end }} | ||
| {{- with .Values.querier.extraContainers }} |
| {{- with .Values.queryFrontend.extraVolumeMounts }} | ||
| {{- toYaml . | nindent 12 }} | ||
| {{- end }} | ||
| {{- with .Values.queryFrontend.extraContainers }} |
Signed-off-by: Arun Cherla <[email protected]>
Signed-off-by: Arun Cherla <[email protected]>
Signed-off-by: Arun Cherla <[email protected]>
3 participants
Linked to: #3729