[tempo-distributed] Fixes #3736: use correct storageClassName for zone-aware ingester PVCs #3737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shityakov
requested review from
Sheikh-Abubaker,
mapno,
swartz-k,
BitProcessor,
faustodavid and
a team
as code owners
|
|
shityakov
force-pushed
the
shityakov-tempo-ingester
branch
2 times, most recently
from
3217b48 to
282ce84
Compare
shityakov
force-pushed
the
shityakov-tempo-ingester
branch
6 times, most recently
from
7ab83c0 to
23d685c
Compare
…ter PVCs Signed-off-by: Andrey Shityakov <[email protected]>
shityakov
force-pushed
the
shityakov-tempo-ingester
branch
from
23d685c to
624e887
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ What this PR does
This PR fixes an issue with the tempo-distributed chart when using zone-aware replication for ingesters.
Specifically, it ensures that the correct storageClassName is passed into the volumeClaimTemplates for each zone.
Previously, the storageClassName value from zones[].storageClass was not used in the generated StatefulSets. This caused the PVCs to default to an incorrect or global storage class, which may lead to provisioning failures or incorrect zone placement.
✅ Changes made
Use the zone-specific storageClass value from the zone map when rendering the PVC block.
🔗 Related issue
Fixes #3736