[tempo] add grafana sidecar datasource to tempo #3742
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
yordis
changed the title
yordis
force-pushed
the
yordis/tempo/add-datasource
branch
4 times, most recently
from
d287615 to
d110ef0
Compare
yordis
requested review from
a team,
BitProcessor,
Sheikh-Abubaker,
dgzlopes,
faustodavid and
swartz-k
as code owners
yordis
force-pushed
the
yordis/tempo/add-datasource
branch
from
d110ef0 to
fbc5f82
Compare
Sheikh-Abubaker
changed the title
yordis
force-pushed
the
yordis/tempo/add-datasource
branch
3 times, most recently
from
7e2ad95 to
b142287
Compare
|
@Sheikh-Abubaker I think it should be ready to code review, please help me with passing CI and a second smoke test if your end if possible 🙏🏻 |
yordis
force-pushed
the
yordis/tempo/add-datasource
branch
2 times, most recently
from
00cf0a0 to
84cf83a
Compare
Signed-off-by: Yordis Prieto <[email protected]>
yordis
force-pushed
the
yordis/tempo/add-datasource
branch
from
84cf83a to
b7646e3
Compare
Signed-off-by: Sheikh-Abubaker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to follow
loki-stackexample https://github.com/grafana/helm-charts/blob/main/charts/loki-stack/templates/datasources.yaml