[tempo-distributed] add service account labels support #3805
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobbs
requested review from
a team,
BitProcessor,
Sheikh-Abubaker,
faustodavid and
swartz-k
as code owners
|
|
nobbs
force-pushed
the
fix/tempo-distributed-serviceaccount-labels
branch
from
c731de3 to
68a59b5
Compare
Collaborator
|
@nobbs could you please resolve the conflicts ? Thanks! |
nobbs
force-pushed
the
fix/tempo-distributed-serviceaccount-labels
branch
from
68a59b5 to
7f6cf0a
Compare
Contributor
Author
|
@Sheikh-Abubaker done! |
Contributor
Author
|
Crap, sorry - incremented the wrong version in a hurry. Will fix that. |
Signed-off-by: Alexej Disterhoft <[email protected]>
nobbs
force-pushed
the
fix/tempo-distributed-serviceaccount-labels
branch
from
7f6cf0a to
57874fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simply adds templating support for service account labels to the
tempo-distributedchart. This is required for various setups in public cloud providers such as GCP or Azure to make use of the respective implementations of workload identity, e.g. for blob storage access.