fix(helm): add headless querier service update tail_proxy_url to use headless service #18576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
daxroc
changed the title
jkroepke
reviewed
Jul 26, 2025
There was a problem hiding this comment.
Hi, thanks for your PR. Please add a note to the CHANGELOG.
It would be great, if a internal Loki employee like @trevorwhitney could take a look here, since he may know what would be the best behavior in that context.
Comment on lines
+10
to
+12
| {{- with .Values.querier.serviceLabels }} | ||
| {{- toYaml . | nindent 4 }} | ||
| {{- end }} |
There was a problem hiding this comment.
Suggested change
| {{- with .Values.querier.serviceLabels }} | |
| {{- toYaml . | nindent 4 }} | |
| {{- end }} | |
| {{- with .Values.querier.serviceLabels }} | |
| {{- toYaml . | nindent 4 }} | |
| {{- end }} | |
| variant: headless | |
| prometheus.io/service-monitor: "false" |
Similar to:
|
@daxroc WDYT? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Creates headless querier service, updates
tail_proxy_urlconfiguration to use headless serviceWhich issue(s) this PR fixes:
Fixes #18482
Special notes for your reviewer:
loki, loki, ConfigMap (v1) has changed: ... frontend: scheduler_address: loki-query-scheduler.loki.svc.cluster.local:9095 - tail_proxy_url: http://loki-querier.loki.svc.cluster.local:3100 + tail_proxy_url: http://loki-querier-headless.loki.svc.cluster.local:3100 loki, loki-querier-headless, Service (v1) has been added: - + apiVersion: v1 + kind: Service + metadata: + annotations: null + labels: + app.kubernetes.io/component: querier + app.kubernetes.io/instance: loki + app.kubernetes.io/name: loki + app.kubernetes.io/version: 3.5.2 + helm.sh/chart: loki-6.33.0 + name: loki-querier-headless + namespace: loki + spec: + clusterIP: None + ports: + - name: http-metrics + port: 3100 + protocol: TCP + targetPort: http-metrics + - name: grpc + port: 9095 + protocol: TCP + targetPort: grpc + selector: + app.kubernetes.io/component: querier + app.kubernetes.io/instance: loki + app.kubernetes.io/name: lokiChecklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR