Skip to content

Conversation

sophiewaldman
Copy link
Contributor

@sophiewaldman sophiewaldman commented Jul 28, 2025

What this PR does / why we need it:
Updates golangci-lint to v2.3.0 and updates the .golangci.yml file accordingly.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:
Blocked by grafana/loki-release#270

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • [n/a] Documentation added
  • [n/a] Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@CLAassistant
Copy link

CLAassistant commented Jul 28, 2025

CLA assistant check
All committers have signed the CLA.

@sophiewaldman sophiewaldman changed the title Chore: Move to golangci-lint v2.3.0 (latest) chore: Move to golangci-lint v2.3.0 (latest) Jul 28, 2025
@trevorwhitney
Copy link
Collaborator

I love this idea! it's annoying to always have to run the linter in a build image (that we're trying to deprecate) because of how old our linter version is!

@sophiewaldman sophiewaldman merged commit 8463330 into main Sep 15, 2025
75 checks passed
@sophiewaldman sophiewaldman deleted the golangci branch September 15, 2025 21:06
JoaoBraveCoding pushed a commit to JoaoBraveCoding/loki that referenced this pull request Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants