feat: add max age to builder #18700
Closed
feat: add max age to builder #18700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| b.state = builderStateDirty | ||
| if b.state == builderStateEmpty { | ||
| b.state = builderStateDirty | ||
| b.firstAppendedAt = now |
There was a problem hiding this comment.
I specifically chose now instead of the record timestamp. If we used the record timestamp, when replaying a partition (i.e. following a crash), we would build one data object per record, which is not what we want.
There was a problem hiding this comment.
I think this might be better implemented at the consumer level, since that's also where we handle the idle timeout. WDYT?
There was a problem hiding this comment.
#18622 exposes the time range for a builder which would make doing this within the consumer possible, but nobody has been able to review it yet
|
💻 Deploy preview available: |
|
Replaced with #18816. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This pull request adds a new flag
max-ageto builders. It fixes a bug where low volume partitions would not have data objects built within a reasonable time.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR