feat: add prepare downscale handler #20007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This PR is stacked on top of #20006. |
| // immediately before the pod is downscaled. It can stop a downscale by | ||
| // responding with a non 2xx status code. | ||
| func (s *Service) PrepareDownscaleHandler(w http.ResponseWriter, r *http.Request) { | ||
| s.partitionInstanceLifecycler.SetRemoveOwnerOnShutdown(true) |
Contributor
Author
There was a problem hiding this comment.
Copied from ingesters.
grobinson-grafana
force-pushed
the
grobinson/add-prepare-downscale-handler
branch
2 times, most recently
from
9daa1cb to
f7d0923
Compare
benclive
approved these changes
Nov 26, 2025
grobinson-grafana
force-pushed
the
grobinson/add-prepare-downscale-handler
branch
from
f7d0923 to
7eb3d91
Compare
grobinson-grafana
deleted the
grobinson/add-prepare-downscale-handler
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This pull request adds a prepare downscale handler so dataobj-consumers remove their ownership of partitions when we downscale. This allows partitions to be cleaned up in the ring.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR