Skip to content

Conversation

jackw
Copy link
Collaborator

@jackw jackw commented Jul 24, 2025

What this PR does / why we need it:

This PR is experimenting with the fallout of enabling auto jsx and externalising reacts jsx runtime in grafana core. Please don't waste time reviewing it now, it's incomplete.

Which issue(s) this PR fixes:

Related grafana/grafana/issues/87598

Special notes for your reviewer:

@jackw jackw self-assigned this Jul 24, 2025
@jackw jackw added create-plugin related to the create-plugin tool minor Increment the minor version when merged release Create a release when this pr is merged labels Jul 24, 2025
Copy link
Contributor

github-actions bot commented Jul 24, 2025

Hello! 👋 This repository uses Auto for releasing packages using PR labels.

✨ This PR can be merged and will trigger a new minor release.
NOTE: When merging a PR with the release label please avoid merging another PR. For further information see here.

@tolzhabayev tolzhabayev moved this from 📬 Triage to 🧑‍💻 In development in Plugins Platform / Grafana Community Jul 25, 2025
@jackw jackw force-pushed the jackw/auto-jsx-runtime branch from 402079c to bc45936 Compare July 29, 2025 08:18
ifrost added a commit to grafana/profiles-drilldown that referenced this pull request Aug 1, 2025
We need either Provide Plugin or change swc-loader config to include:

{
  jsc: {
    transform: {
      react: {
        runtime: 'automatic',
      },
    },
  },
}

But swc-loader config is part of common config for each plugin (which we need to update anyway soon) so this might be a bit more clean.

We can update build config to latest once grafana/plugin-tools#1986 is merged

This is required now because of grafana/grafana#88802
@jackw jackw force-pushed the jackw/auto-jsx-runtime branch from 4de7b65 to 18fee58 Compare September 8, 2025 08:04
ifrost added a commit to grafana/profiles-drilldown that referenced this pull request Sep 8, 2025
* Ensure React is available in global scope

We need either Provide Plugin or change swc-loader config to include:

{
  jsc: {
    transform: {
      react: {
        runtime: 'automatic',
      },
    },
  },
}

But swc-loader config is part of common config for each plugin (which we need to update anyway soon) so this might be a bit more clean.

We can update build config to latest once grafana/plugin-tools#1986 is merged

This is required now because of grafana/grafana#88802

* Hide Assistant button and keep using LLM if Assistant is not available

* Update FlameGraph package

* Add grafana/assistant

* Update docker config

* Update tests

* Fix linting

* Remove webpack changes
@jackw jackw force-pushed the jackw/auto-jsx-runtime branch from 18fee58 to d67d273 Compare September 17, 2025 13:42
@jackw jackw force-pushed the jackw/auto-jsx-runtime branch from d67d273 to 5311bf8 Compare September 18, 2025 12:56
Copy link
Contributor

Playwright test results

Plugin Name Image Name Version Result Report
myorg-nobackend-panel grafana-enterprise latest View report
myorg-nobackend-panel grafana-enterprise 10.4.0 View report
Troubleshooting

404 when clicking on View report

By default, the deploy-report-pages Action deploys reports to the gh-pages branch. However, you need to take an extra step to ensure that GitHub Pages can build and serve the site from this branch. To do so:

  1. Go to the Settings tab of your repository.
  2. In the left-hand sidebar, click on Pages.
  3. Under Source, select Deploy from a branch, then choose the gh-pages branch.

This action needs to be completed manually in order for your GitHub Pages site to be built and accessible from the gh-pages branch. Once configured, GitHub will automatically build and serve the site whenever new reports are deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
create-plugin related to the create-plugin tool minor Increment the minor version when merged release Create a release when this pr is merged
Projects
Status: 🧑‍💻 In development
Development

Successfully merging this pull request may close these issues.

1 participant