-
Notifications
You must be signed in to change notification settings - Fork 33
[WIP] Create Plugin: Automatic JSX runtime #1986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
402079c
to
bc45936
Compare
We need either Provide Plugin or change swc-loader config to include: { jsc: { transform: { react: { runtime: 'automatic', }, }, }, } But swc-loader config is part of common config for each plugin (which we need to update anyway soon) so this might be a bit more clean. We can update build config to latest once grafana/plugin-tools#1986 is merged This is required now because of grafana/grafana#88802
4de7b65
to
18fee58
Compare
* Ensure React is available in global scope We need either Provide Plugin or change swc-loader config to include: { jsc: { transform: { react: { runtime: 'automatic', }, }, }, } But swc-loader config is part of common config for each plugin (which we need to update anyway soon) so this might be a bit more clean. We can update build config to latest once grafana/plugin-tools#1986 is merged This is required now because of grafana/grafana#88802 * Hide Assistant button and keep using LLM if Assistant is not available * Update FlameGraph package * Add grafana/assistant * Update docker config * Update tests * Fix linting * Remove webpack changes
18fee58
to
d67d273
Compare
d67d273
to
5311bf8
Compare
Playwright test results
Troubleshooting404 when clicking on
|
What this PR does / why we need it:
This PR is experimenting with the fallout of enabling auto jsx and externalising reacts jsx runtime in grafana core. Please don't waste time reviewing it now, it's incomplete.
Which issue(s) this PR fixes:
Related grafana/grafana/issues/87598
Special notes for your reviewer: