-
Notifications
You must be signed in to change notification settings - Fork 39
Add optional unwind dependency to py-spy to enable native tracing #227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Gowtham Sundara seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
The unwind feature has been disabled and removed from pyroscope-rs to "reduce maintenance surface". |
@korniltsev What would be the recommended alternative? Should I use the alloy ebpf tracer |
Can you share what is your use case? What type of app do you have to profile? How do stack traces look if obtained from py-spy? You may try alloy's |
Yes, this is perfectly valid use case. We need either bring back libunwind ( :( ) or have native unwinding in rust. |
@HackToHell would you like to continue work on this and revert my changes that removed libunwind? Or would you prefer me to do this? |
Since benfred/py-spy#768 unwind became optional, unfortunately without this, native=True flag doesn't really work.
The commit is synced into grafana/py-spy as well.