feat: annotate sampled profiles #4375
Merged
+115
−58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleks-p
force-pushed
the
feat/annotate-sampled-profiles
branch
from
f454f27 to
a6250c7
Compare
korniltsev
reviewed
Aug 15, 2025
| PeriodLimitMb int `json:"periodLimitMb"` | ||
| LimitResetTime int64 `json:"limitResetTime"` | ||
| SamplingPeriodSec int `json:"samplingPeriodSec"` | ||
| SamplingRequests int `yaml:"samplingRequests"` |
There was a problem hiding this comment.
whoops, good thing is it hasn't been used yet :)
korniltsev
reviewed
Aug 15, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for annotating sampled profiles with distributor sampling information. This allows profiling UIs to visualize sampling and enables future metrics adjustments based on sampling data.
Key changes:
- Introduces a new annotation system for tracking sampling sources with usage group and probability information
- Refactors existing throttling annotations to use a centralized annotation package
- Updates sampling logic to return sampling source information instead of just usage group matches
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/distributor/sampling/config.go | Adds Source struct to track sampling metadata |
| pkg/distributor/annotation/annotation.go | New shared annotation constants and types |
| pkg/distributor/annotation/throttling.go | Refactored throttling annotation logic from ingestlimits |
| pkg/distributor/annotation/sampling.go | New sampling annotation creation logic |
| pkg/distributor/model/push.go | Updates to use new annotation package and adds MarkSampledRequest method |
| pkg/distributor/distributor.go | Modified sampling logic to track and annotate sampling sources |
| pkg/distributor/model/push_test.go | Updated test references to new annotation constants |
| pkg/distributor/distributor_test.go | Updated test expectations for new sampling.Source return type |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| PeriodLimitMb int `json:"periodLimitMb"` | ||
| LimitResetTime int64 `json:"limitResetTime"` | ||
| SamplingPeriodSec int `json:"samplingPeriodSec"` | ||
| SamplingRequests int `yaml:"samplingRequests"` |
There was a problem hiding this comment.
The struct tag should be json:"samplingRequests" instead of yaml:"samplingRequests" to match the other fields in this JSON-serialized struct.
Suggested change
| SamplingRequests int `yaml:"samplingRequests"` | |
| SamplingRequests int `json:"samplingRequests"` |
Copilot uses AI. Check for mistakes.
Co-authored-by: Tolya Korniltsev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Annotating profiles that are subject to distributor sampling. Similar to #3956, with a bit of refactoring to make things cleaner. The annotations will allow sampling to be visualized in profiling UIs and in the future adjust metrics generated from profiles (cc @alsoba13).