fix: limit max nodes in symbolization queries #4629
Merged
+16
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
reviewed
Nov 20, 2025
simonswine
reviewed
Nov 20, 2025
…rafana/pyroscope into marcsanmi/honor-maxnodes-symbolization
Contributor
Author
|
Can you quickly (re)review @simonswine? I've just used |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use validated
Tree.MaxNodesdirectly when converting TREE to PPROF queries for symbolization. This should prevent unbounded resource usage during symbolization while still allowing processing of large profiles.Also increased query backend client timeout from 20s to 30s.