[audit-01] fix: [TRST-H-1] IndexingAgreement.collect() on CanceledByPayer #1198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matiasedgeandnode
changed the title
fix: [TRST-H-1] IndexingAgreement.collect() on CanceledByPayer
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
pcarranzav
approved these changes
Jul 25, 2025
| @@ -413,4 +413,11 @@ interface IRecurringCollector is IAuthorizable, IPaymentsCollector { | |||
| * @return The AgreementData struct containing the agreement's data. | |||
| */ | |||
| function getAgreement(bytes16 agreementId) external view returns (AgreementData memory); | |||
|
|
|||
| /** | |||
| * @notice Checks if an agreement is collectable. | |||
There was a problem hiding this comment.
nit: might be worth explaining what it means that an agreement is collectable? (it could be misunderstood as meaning there are actually funds to collect)
| skip(_expectedTokens.expectedTotalTokensCollected / terms.tokensPerSecond); | ||
| } | ||
|
|
||
| function _newExptectedTokens(uint256 _fuzzyTokensCollected) internal view returns (ExpectedTokens memory) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.