[audit-06] fix: [TRST-M-3] Add nonce-based replay protection #1203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matiasedgeandnode
commented
Jul 23, 2025
matiasedgeandnode
commented
[audit-06] fix: [TRST-M-3] Add nonce-based replay protection
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
matiasedgeandnode
changed the title
pcarranzav
approved these changes
Jul 31, 2025
matiasedgeandnode
force-pushed
the
ma/indexing-payments-audit-fixes-05-M-2
branch
from
eec5ea6 to
17355fe
Compare
matiasedgeandnode
force-pushed
the
ma/indexing-payments-audit-fixes-06-M-3
branch
from
117672c to
e5fefbe
Compare
matiasedgeandnode
force-pushed
the
ma/indexing-payments-audit-fixes-05-M-2
branch
from
17355fe to
345cfc8
Compare
Fixes signature replay attack vulnerability where old signed RecurringCollectionAgreementUpdate messages could be replayed to revert agreements to previous terms. ## Changes - Add `nonce` field to RecurringCollectionAgreementUpdate struct (uint32) - Add `updateNonce` field to AgreementData struct to track current nonce - Add nonce validation in RecurringCollector.update() to ensure sequential updates - Update EIP712_RCAU_TYPEHASH to include nonce field - Add comprehensive tests for nonce validation and replay attack prevention - Add RecurringCollectorInvalidUpdateNonce error for invalid nonce attempts ## Implementation Details - Nonces start at 0 when agreement is accepted - Each update must use current nonce + 1 - Nonce is incremented after successful update - Uses uint32 for gas optimization (supports 4B+ updates per agreement) - Single source of truth: nonce stored in AgreementData struct
matiasedgeandnode
force-pushed
the
ma/indexing-payments-audit-fixes-06-M-3
branch
from
e5fefbe to
8b2e93a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.