[audit-07] fix: [TRST-L-3] Add deterministic agreement ID #1204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matiasedgeandnode
commented
Jul 23, 2025
matiasedgeandnode
commented
fix: [TRST-L-3] Add deterministic agreement ID
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
matiasedgeandnode
changed the title
pcarranzav
approved these changes
Jul 31, 2025
| { | ||
| IndexingAgreement._getStorageManager().accept(_allocations, allocationId, signedRCA); |
There was a problem hiding this comment.
nit: NatSpec missing for the new return value
| @@ -264,7 +264,10 @@ interface ISubgraphService is IDataServiceFees { | |||
| * @param allocationId The id of the allocation | |||
| * @param signedRCA The signed recurring collector agreement (RCA) that the indexer accepts | |||
There was a problem hiding this comment.
nit: NatSpec for return value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.