[audit-11] fix: [TRST-L-9] Cancel agreement if over-allocated #1208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matiasedgeandnode
commented
Jul 24, 2025
matiasedgeandnode
commented
matiasedgeandnode
force-pushed
the
ma/indexing-payments-audit-fixes-11-L-9
branch
from
5c90356 to
dbe49d5
Compare
matiasedgeandnode
changed the title
[audit-11] fix: [TRST-L-9] Cancel agreement if over-allocated
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Maikol
approved these changes
Jul 31, 2025
| paymentsDestination[_indexer] | ||
| ); | ||
|
|
||
| if (allocationForceClosed) { |
There was a problem hiding this comment.
Another option would be checking the allocation storage for the state after calling presentPOI it's slightly more expensive but we save on contract size, though I'm not sure where we're at with the new libraries.
There was a problem hiding this comment.
SubgraphService is ~23.4kb - So rather close.
pcarranzav
approved these changes
Jul 31, 2025
matiasedgeandnode
force-pushed
the
ma/indexing-payments-audit-fixes-10-L-7
branch
from
3e8d93b to
087f300
Compare
matiasedgeandnode
force-pushed
the
ma/indexing-payments-audit-fixes-11-L-9
branch
from
dbe49d5 to
9423bfa
Compare
matiasedgeandnode
force-pushed
the
ma/indexing-payments-audit-fixes-10-L-7
branch
from
087f300 to
308d6e6
Compare
matiasedgeandnode
force-pushed
the
ma/indexing-payments-audit-fixes-11-L-9
branch
from
9423bfa to
17b794e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.