Add and improve tests.

Author: gregschmit

lib/rest_framework/serializers/active_model_serializer_adapter_factory.rb

@@ -1,5 +1,6 @@
 # This is a helper factory to wrap an ActiveModelSerializer to provide a `serialize` method which
 # accepts both collections and individual records. Use `.for` to build adapters.
+# :nocov:
 class RESTFramework::Serializers::ActiveModelSerializerAdapterFactory
   def self.for(active_model_serializer)
     return Class.new(active_model_serializer) do
@@ -13,6 +14,7 @@ def serialize
     end
   end
 end
+# :nocov:
 
 # Alias for convenience.
 # rubocop:disable Layout/LineLength

lib/rest_framework/serializers/base_serializer.rb

@@ -16,6 +16,7 @@ def serialize(*args)
   end
 
   # Synonym for `serialize` for compatibility with `active_model_serializers`.
+  # :nocov:
   def serializable_hash(*args)
     return self.serialize(*args)
   end
@@ -34,6 +35,7 @@ def self.fragment_cache_enabled?
   def associations(*args, **kwargs)
     return []
   end
+  # :nocov:
 end
 
 # Alias for convenience.

test/app/controllers/api/test/unknown_model_controller.rb

@@ -0,0 +1,3 @@
+class Api::Test::UnknownModelController < Api::TestController
+  include RESTFramework::ModelControllerMixin
+end

test/config/routes.rb

@@ -50,6 +50,7 @@
       rest_resources :fields_hash_only_except
       rest_resources :no_rescue_unknown_format
       rest_resources :read_only
+      rest_resources :unknown_model
       rest_resources :users_with_sub_fields
 
       rest_route :network

test/test/controllers/api/demo/movies_controller_test.rb

@@ -12,6 +12,12 @@ def test_ransack_simple
       assert_response(:success)
       assert_equal(Movie.where("price > 9").count, @response.parsed_body.length)
     end
+
+    def test_ransack_distinct
+      get(:index, as: :json, params: {q: {price_gt: 9}, distinct: true, page_size: 0})
+      assert_response(:success)
+      assert_equal(Movie.where("price > 9").count, @response.parsed_body.length)
+    end
   end
 
   def test_bulk_create
@@ -139,4 +145,40 @@ def test_filtering_predicates
     assert_response(:success)
     assert_equal(5, @response.parsed_body.length)
   end
+
+  def test_subfield_predicate
+    # This feature is only available in Rails 7 and above.
+    return if Rails::VERSION::MAJOR < 7
+
+    get(:index, as: :json, params: {"main_genre.name_in" => "History,Fantasy", page_size: 0})
+    assert_response(:success)
+    assert_equal(
+      Genre.where(name: ["History", "Fantasy"]).collect { |g| g.main_movies }.flatten.count,
+      @response.parsed_body.length,
+    )
+  end
+
+  def test_search
+    get(:index, as: :json, params: {search: "for", page_size: 0})
+    assert_response(:success)
+    assert_operator(@response.parsed_body.length, :<, Movie.count)
+  end
+
+  def test_ordering
+    get(:index, as: :json, params: {ordering: "name", page_size: 0})
+    assert_response(:success)
+    assert_equal(Movie.order("name").pluck(:id), @response.parsed_body.map { |r| r["id"] })
+  end
+
+  def test_page_2
+    get(:index, as: :json, params: {page: 2, page_size: 2})
+    assert_response(:success)
+    assert_equal(2, @response.parsed_body["results"].length)
+  end
+
+  def test_page_0
+    get(:index, as: :json, params: {page: 0, page_size: 2})
+    assert_response(:success)
+    assert_equal(2, @response.parsed_body["results"].length)
+  end
 end

test/test/controllers/api/test/unknown_model_controller_test.rb

@@ -0,0 +1,9 @@
+require "test_helper"
+
+class Api::Test::UnknownModelControllerTest < ActionController::TestCase
+  def test_unknown_model_raised
+    assert_raises(RESTFramework::UnknownModelError) do
+      get(:index)
+    end
+  end
+end