Parse arithmetic #14
Open
Parse arithmetic #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And a small fix to the previous commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I feel like this is ready for initial PR review. There's still cleanup todo, there's still one failing arithmetic test case (but it's because it has to do with escaped newlines, which requires fixes elsewhere, to discuss), but otherwise, it works.
I also need feedback on the names of nodes; i roughly named them after estree, but the consistency changed later on as I reused existing rules.
It's also a lot looser than what zsh or bash allows, w.r.t. strings inside of arithmetic expressions -- i need to see what shellcheck bases these tests on, or if there's specific flags in bash/zsh to allow strings / concatenation in arithmetic expressions.
🎉