grpc: Deprecate InitialWindowSize and introduce InitialStreamWindowSize #8665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of grpc#7923. Since it has been two releases after grpc#8283 is merged, we can introduce InitialStreamWindowSize on both server and client, while deprecating InitialWindowSize. RELEASE NOTES: * grpc: Introduce new ServerOption and ClientOption to set stream window size without disabling BDP estimation. * grpc: Behavior change in WithInitialWindowSize in ClientOption and InitialWindowSize in ServerOption. Using these options will no longer disable BDP estimation. To explicitly disable BDP estimation, please use *StaticStreamWindowSize options. * grpc: Mark WithInitialWindowSize for deprecation, to be replaced with WithInitialStreamWindowSize in ClientOption. Similarly, for InitialWindowSize inServerOption to be replaced with InitialStreamWindowSize.
Pramodh-G
force-pushed
the
fix-window-options
branch
from
006cadf to
1a6265f
Compare
|
@Pramodh-G , the tests seem to be failing , could you please make sure that the tests are passing before we review it? |
eshitachandwani
added
the
Type: Behavior Change
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #8665 +/- ##
==========================================
+ Coverage 81.97% 81.99% +0.02%
==========================================
Files 417 417
Lines 40788 40806 +18
==========================================
+ Hits 33435 33459 +24
+ Misses 5991 5957 -34
- Partials 1362 1390 +28
🚀 New features to boost your workflow:
|
|
@eshitachandwani / @dfawley: Please take a look. Tests are passing now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #7923.
Since it has been two releases after #8283 is merged, we can introduce
InitialStreamWindowSizeon both server and client, while deprecatingInitialWindowSize.RELEASE NOTES:
grpc: Introduce new
ServerOptionandClientOptionto set stream window size without disabling BDP estimation.grpc: Behavior change in
WithInitialWindowSizeinClientOptionandInitialWindowSizeinServerOption. Using these options will no longer disable BDP estimation. To explicitly disable BDP estimation, please use `StaticStreamWindowSize options.grpc: Mark
WithInitialWindowSizefor deprecation, to be replaced withWithInitialStreamWindowSizeinClientOption. Similarly, forInitialWindowSizeinServerOption to be replaced withInitialStreamWindowSize.