Skip to content

Conversation

@twz123
Copy link

@twz123 twz123 commented Oct 21, 2025

Three goroutines could outlive a call to ClientConn.close(). Add mechanics to cancel them and wait for them to complete when closing a client connection.

Fixes #8655.

RELEASE NOTES:

  • Closing a client connection will cancel all pending goroutines and block until they complete.

Three goroutines could outlive a call to ClientConn.close(). Add
mechanics to cancel them and wait for them to complete when closing a
client connection.

RELEASE NOTES:
- Closing a client connection will cancel all pending goroutines and
  block until they complete.

Signed-off-by: Tom Wieczorek <[email protected]>
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 91.35802% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.99%. Comparing base (58d4b2b) to head (e45e9d7).

Files with missing lines Patch % Lines
clientconn.go 84.09% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8666      +/-   ##
==========================================
+ Coverage   81.76%   81.99%   +0.22%     
==========================================
  Files         417      417              
  Lines       40806    40858      +52     
==========================================
+ Hits        33367    33501     +134     
+ Misses       6057     5973      -84     
- Partials     1382     1384       +2     
Files with missing lines Coverage Δ
balancer_wrapper.go 86.56% <100.00%> (+2.88%) ⬆️
internal/balancer/gracefulswitch/gracefulswitch.go 86.22% <100.00%> (-1.17%) ⬇️
internal/testutils/pipe_listener.go 84.44% <100.00%> (+2.39%) ⬆️
clientconn.go 90.40% <84.09%> (+1.86%) ⬆️

... and 18 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@eshitachandwani eshitachandwani added this to the 1.77 Release milestone Oct 22, 2025
@eshitachandwani eshitachandwani self-requested a review October 22, 2025 08:26
@eshitachandwani eshitachandwani self-assigned this Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow waiting for all goroutines to exit on client connection close

2 participants