Skip to content

simplify BlockingClientCall infinite blocking #12217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2025

Conversation

benjaminp
Copy link
Contributor

Move deadline computation into overloads with finite timeouts. Blocking calls without timeouts now do not have to read the clock.

Move deadline computation into overloads with finite timeouts. Blocking calls without timeouts now do not have to read the clock.
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the one small change, this looks good to me.

@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jul 24, 2025
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jul 24, 2025
@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jul 24, 2025
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Jul 24, 2025
@ejona86 ejona86 merged commit ba0a732 into grpc:master Jul 29, 2025
20 of 21 checks passed
@ejona86
Copy link
Member

ejona86 commented Jul 29, 2025

@benjaminp, thank you!

@benjaminp benjaminp deleted the BlockingClientCall-infinite-blocking branch July 29, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants