Skip to content

Conversation

marcprux
Copy link

This PR follows-up #2206 and fixes the Android build I noticed at https://swift-everywhere.org.

Hopefully we will soon have CI support for Android (swiftlang/github-workflows#106) to catch this sort of breakage sooner.

Copy link

linux-foundation-easycla bot commented Mar 14, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@glbrntt
Copy link
Collaborator

glbrntt commented Mar 17, 2025

Hi @marcprux -- thanks for opening this PR. You'll need to sign the CLA first though.

@marcprux
Copy link
Author

Hi @marcprux -- thanks for opening this PR. You'll need to sign the CLA first though.

Done!

@glbrntt glbrntt added the 🔨 semver/patch No public API change. label Mar 17, 2025
Copy link
Collaborator

@glbrntt glbrntt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@glbrntt glbrntt enabled auto-merge (squash) March 17, 2025 13:30
@glbrntt glbrntt disabled auto-merge March 17, 2025 13:30
@glbrntt
Copy link
Collaborator

glbrntt commented Mar 17, 2025

@marcprux could you merge the latest changes from main? GitHub isn't giving me the option to do it on your behalf (I suspect there may be a conflict.)

@marcprux
Copy link
Author

@marcprux could you merge the latest changes from main?

Merged!

@glbrntt glbrntt enabled auto-merge (squash) March 17, 2025 13:43
@glbrntt glbrntt merged commit 1470451 into grpc:main Mar 17, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants