gio: add FileEnumerator::into_stream #1035
Conversation
jf2048
force-pushed
the
file-enumerator-stream
branch
from
4ca6fa1 to
27a015e
Compare
| } | ||
|
|
||
| impl futures_core::Stream for FileEnumeratorStream { | ||
| type Item = Result<Vec<FileInfo>, glib::Error>; |
There was a problem hiding this comment.
Why not a glib::List<FileInfo>?
There was a problem hiding this comment.
tbh, I'd leave glib::List to API that interface directly with C. This is a Rust convenience, so I'd recommend using native/idiomatic Rust type wherever possible.
There was a problem hiding this comment.
glib::List works as an Iterator so that for the majority of uses it should be equivalent except for not having to copy over everything into a Vec.
There was a problem hiding this comment.
This is just passing the vec from the underlying next_files_future, it is already converted by the time the stream gets it. It should probably be changed in gir to use List, and then it can be changed here
There was a problem hiding this comment.
Maybe this could be implemented with https://docs.rs/futures-util/latest/futures_util/stream/struct.IntoStream.html?
But then we can't specify the needed arguments, like the number of files... Feel free to ignore this comment.
|
That is only for a single element stream unfortunately, no first-class support for it like |
4 participants
cc @ebassi