[Announcement] Migrate block JSON types to use Ruby identifiers #11035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sampoder
approved these changes
Jul 26, 2025
Member
sampoder
left a comment
sampoder
left a comment
There was a problem hiding this comment.
lgtm! will run one time job when this deploys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the problem
We shouldn't have two different types for each block - changing all block types to be the class identifier is clearer.
Describe your changes
Changed the types used in the ProseMirror JSON to use Ruby class identifier strings, and added a job to migrate existing content over.
Warning
The job
OneTimeJobs::MigrateBlockTypesshould be run once this is deployed.