[Announcement] Add validation for unauthorized HCB code block #11038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polypixeldev
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
garyhtou
reviewed
Jul 23, 2025
garyhtou
reviewed
Jul 23, 2025
Co-authored-by: Gary Tou <[email protected]>
Co-authored-by: Gary Tou <[email protected]>
Co-authored-by: Gary Tou <[email protected]>
sampoder
approved these changes
Jul 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the problem
We're not currently doing any validations on when blocks are saved, and leaving checking that any parameters are valid until we render the block. Now that blocks are in the database, we can easily use validations to not save any invalid data in the first place.
Describe your changes
Added a validation to the HCB code block that makes sure that it is in the same event as the announcement the block is a part of, and alerts it to the user with a browser alert (this will be changed to something nicer in a future PR). The existing checks in
renderare not removed since invalid data could still be in the database or be added with a Rails method that does not check validations.