[Documents] Can now categorize documents when uploading #11065
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I know you might be thinking "What about preexisting documents?". Well almost every document on the documents tab is a common document which can be modified in the common documents section. In terms of organization specific documents, the only one that comes to my mind is fiscal sponsorship documents which are defaulted to general and are supposed to be general according to the attached issue. |
sampoder
reviewed
Jul 23, 2025
app/views/documents/index.html.erb
Outdated
Comment on lines
25
to
42
| <h3> General documents </h3> | ||
| <div class="grid grid-cols-3 gap-4"> | ||
| <%= render partial: "document", collection: @active_common_documents.general %> | ||
| <%= link_to event_fiscal_sponsorship_letter_path(event_id: @event.slug, format: "pdf") do %> | ||
| <li class="card card--hover h-100 w-fit"> | ||
| <div class="overflow-hidden" style="max-height: 250px;"> | ||
| <%= image_tag event_fiscal_sponsorship_letter_url(event_id: @event.slug, format: "png"), width: 330, style: "max-width: 100%;" %> | ||
| </div> | ||
| <strong class="h3 block mt1 line-height-2">Fiscal Sponsorship Confirmation</strong> | ||
| <%= user_mention @event.point_of_contact %> | ||
| </li> | ||
| <% end %> | ||
| </div> | ||
|
|
||
| <h3> Nonprofit documents </h3> | ||
| <div class="grid grid-cols-3 gap-4"> | ||
| <%= render partial: "document", collection: @active_common_documents.nonprofit_status %> | ||
| </div> |
Member
There was a problem hiding this comment.
What differentiates a general document from a nonprofit document?
Contributor
Author
There was a problem hiding this comment.
Its described in #10716 but I would assume documents like the statement of lost receipt is not a directly related to a non-profit document?
YodaLightsabr
previously requested changes
Jul 23, 2025
sampoder
reviewed
Jul 26, 2025
sampoder
reviewed
Jul 26, 2025
sampoder
approved these changes
Jul 26, 2025
Member
sampoder
left a comment
sampoder
left a comment
There was a problem hiding this comment.
code lgtm! thank you Sarvesh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the problem
Currently, there is no way to categorize documents on the documents tab and it makes the documents tab look very messy. Orgs are finding it hard to determine what document is used for what so it might be useful to have categories for them.
ew its so disorganized ^ 🤮
Describe your changes
Added an enum to store what category a document is part of. Also created a DB migration file to create a column on the table for this. Also added scopes to filter out by category.
Wow look at these categories ^ 🤩
^ 😮 new sick dropdown to select categories when uploading a document (also seen in the edit page)
Fixes #10716