-
Notifications
You must be signed in to change notification settings - Fork 65
[DX] Make the test suite work without credentials or external calls #11751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
davidcornu
merged 20 commits into
hackclub:main
from
davidcornu:david/push-zxmoqxwzlqwz
Sep 29, 2025
Merged
[DX] Make the test suite work without credentials or external calls #11751
davidcornu
merged 20 commits into
hackclub:main
from
davidcornu:david/push-zxmoqxwzlqwz
Sep 29, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19886fb
to
e748f42
Compare
garyhtou
approved these changes
Sep 29, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is very nice to have!
require "rails_helper" | ||
|
||
RSpec.describe Donation, type: :modal do | ||
RSpec.describe Donation, type: :model do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the problem
Prior art
WebMock
to catch network calls in tests #10829OrganizerPositionInvitesController#create
#11230 (which added WebMock)Because our test suite makes external API calls and relies on certain credentials being available,
Describe your changes
I commented out my local
.env
file, configured WebMock to block all requests, and chipped away at all the errors until the whole thing ran successfully. This ended up involving:TEST_URL_HOST
(this seems like an odd thing to require in the first place)Lockbox
if one isn't configured (only in the test env)ActoveRecord::Encryption
if they aren't configured (only in the test env)EuCentralBank
values for use in the test envWhen (2), (3), and (4) take effect we log the ephemeral values to STDERR:
I've also removed
WebMock.allow_net_connect!
so any newly-introduced network calls will fail.Notes