-
Couldn't load subscription status.
- Fork 0
Motion sensor delay #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
pidge
wants to merge
6
commits into
main
Choose a base branch
from
claude/ac-motion-sensor-control-011CUQZ8rC9w47Ybx5caiCEZ
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Motion sensor delay #1
pidge
wants to merge
6
commits into
main
from
claude/ac-motion-sensor-control-011CUQZ8rC9w47Ybx5caiCEZ
+151
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Connect PIR motion sensor on GPIO pin 2 - Track last motion time and only send AC OFF after 1 hour of no motion - Reset AC off flag when motion is detected to allow re-triggering - Add serial output for debugging motion detection and AC commands - Compatible with Adafruit PIR sensor (product #4871) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Test compilation on Arduino Uno, ESP8266, and ESP32 boards - Verify both ir_sender and ir_receiver sketches build successfully - Install IRremote library v4.1.2 as required by the code - Run on all pushes and pull requests 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
- Migrate from old IRremote 2.x API to 4.x API for consistency - Change include from <IRremote.h> to <IRremote.hpp> - Use IrReceiver global object instead of IRrecv class - Update decode() method and data access patterns - Convert rawbuf values using MICROS_PER_TICK for correct timing - Update dump() function to use new API and IrSender naming This fixes CI build failures by ensuring both sketches use the same IRremote library version (4.1.2). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Replace manual raw buffer access with library helper functions: - Use printIRResultShort() for formatted output - Use printIRSendUsage() to print C array format for sender - Remove custom dump() function that accessed rawDataPtr - Simplify code to use only well-documented API functions This should fix compilation errors by using stable, documented IRremote 4.x API instead of trying to access internal structures. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
@claude CI is failing dude |
IRremote 4.1.2 is incompatible with ESP32 Arduino core 3.x due to deprecated timer API functions. Version 4.4.1 includes fixes for ESP32 core 3.x compatibility. Changes: - Update CI workflow to install [email protected] - Update version comments in both sketches - Tested locally on all three platforms (Uno, ESP8266, ESP32) - All builds pass successfully Fixes ESP32 compilation errors: - timerAlarmEnable/timerAlarmDisable not declared - timerBegin/timerAttachInterrupt signature changes - ledcSetup/ledcAttachPin not declared 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Add sketch.yaml files to both sketches defining build profiles for: - Arduino Uno (AVR) - ESP8266 (NodeMCU v2) - ESP32 Update CI workflow to use profile-based compilation instead of manual platform/library installation. This provides: - Isolated, reproducible builds - Auto-download of dependencies - Consistent behavior between local dev and CI - Simplified CI configuration Each profile specifies: - FQBN (Fully Qualified Board Name) - Platform version - IRremote library version (4.4.1) - Platform index URLs for ESP boards 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
|
@md1024 Claude has some code for you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to check actual PIR pin and trigger level.