Upstream cleanup js #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move ping server code and LANG_CODE replacement from several sites to a common file.
Use a listener in the document root instead of adding a handler to each node. As a bonus, images inside translation blocks can be clicked now, solving https://dev.haiku-os.org/ticket/15871
The text and fuzzy variables are updated even when the server does not accept a change. The block is marked and the edit window is kept open, but the user may just cancel and the block will keep the incorrect text, instead of going back to the original. Update the variables only for accepted changes, so that on cancel the page reflects the real values.
Also fixes the title not being translated on load.
Add unreachable blocks like in the translate tool, so that they can be edited like body blocks.
Directly loop through the nodes marked as translatable blocks, instead of recursively visiting each node and its children to find them.
lonemadmax
force-pushed
the
upstream-cleanup-js
branch
from
498bad1 to
7b6791d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collect and rewrite some js code dealing with translation/edit.
Based off #9.