Refactor mdm expander holder out #7295
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 9, 2025 16:22
Contributor
|
Formatting check succeeded! |
This reverts commit 3844dc6.
added 3 commits
October 17, 2025 12:48
…ributed, and we need a better approach.
fil512
approved these changes
Oct 20, 2025
| IHapiTransactionService theHapiTransactionService, | ||
| ISearchParamRegistry theSearchParamRegistry, | ||
| MdmExpandersHolder theMdmExpandersHolder) { | ||
| Optional<IMdmLinkExpandSvc> theMdmLinkExpandSvc) { |
Collaborator
There was a problem hiding this comment.
optional arguments is an antipattern
https://cloud-ci.sgs.com/sonar/coding_rules?open=java%3AS3553&rule_key=java%3AS3553
| } | ||
|
|
||
| private String submitBulkExportForTypesWithExportId(String theExportId, String... theTypes) throws IOException { | ||
| String typeString = String.join(",", theTypes); |
Collaborator
There was a problem hiding this comment.
do we need to sanitize theTypes?
| Set<String> expandMdmByGoldenResourceId(RequestPartitionId theRequestPartitionId, IIdType theId); | ||
|
|
||
| /** | ||
| * For the Group resource with the given id, returns all the persistent id ofs |
Collaborator
There was a problem hiding this comment.
Suggested change
| * For the Group resource with the given id, returns all the persistent id ofs | |
| * For the Group resource with the given id, returns all the persistent ids of |
| Set<JpaPid> expandGroup(String groupResourceId, RequestPartitionId requestPartitionId); | ||
|
|
||
| /** | ||
| * annotates the given resource to be exported with the implementation specific extra information if applicable |
| */ | ||
| default boolean supportsEidBasedExpansion() { | ||
| return getMode().equals(MdmModeEnum.MATCH_ONLY) | ||
| && !getMdmRules().getEnterpriseEIDSystems().isEmpty(); |
Collaborator
There was a problem hiding this comment.
do we want to check entries are not blank as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.