Skip to content

Conversation

PathogenDavid
Copy link
Member

(This PR was created semi-automatically.)

This PR brings extremely bare-bones CI/CD for the interface package to aid with the Bonsai 2.9 release. It is not indicative of long-term plans for improved Harp CI/CD.

Note: Some Harp devices had their PackageType added by Bruno and have already been published on NuGet.org.

@PathogenDavid PathogenDavid requested a review from glopesdev May 17, 2025 05:29
@MicBoucinha
Copy link
Contributor

MicBoucinha commented May 20, 2025

Hi @PathogenDavid, were the changes to the files under App due to line endings?

@PathogenDavid
Copy link
Member Author

@MicBoucinha Correct, it was an indirect consequence of adding the .gitattributes. (Detailed explanation below past the screenshot if you're curious)

The setting is a bit hidden, but you ask GitHub to collapse whitespace-only changes:

image


Git's default behavior when text isn't specified is unfortunately to rely on the user's global core.autocrlf setting, and text controls whether or not CRLF line endings get converted to LF when the files get stored within the repo. Adding a .gitattributes with a default text for all files fixes this inconsistency.

Unlike everything else in this repo, these few files got stored with CRLF line endings when they were originally added. (You might have multiple computers with differing settings, which is very easy to do by accident because the Git for Windows installer prompts you to choose one. Using WSL and changing your core.autocrlf setting after install can also easily lead to this happening.)

Having CRLF files stored in the repo when autocrlf or text are enabled can cause odd behavior in Git, so I normalized them to LF to save someone the future frustration.

@MicBoucinha
Copy link
Contributor

Thanks for the detailed explanation. I will check my devices to confirm which one might have a different configuration for that property. Cheers!

@PathogenDavid
Copy link
Member Author

No problem!

You might find it helpful to use git config --get core.autocrlf to check the effective value since there's lots of places git configuration can come from. (The installer-configured default lives in C:\Program Files\Git\etc\gitconfig if you want to check that specifically.)

@CLAassistant
Copy link

CLAassistant commented Jun 9, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants