Skip to content

Conversation

@github-actions
Copy link
Contributor

Backport

This PR is auto-generated from #37810 to be assessed for backporting due to the inclusion of the label 1.14-backport.

The below text is copied from the body of the original PR.


The CheckPrior function results validation did not take into account unknown values, because unknown values were not originally allowed in the plugin protocol from which this check was adapted.

The test is simple, in that we can just reverse the check which originally didn't allow this change in value. Provider function return values types are defined by the protocol, and should be validated at that call site. The CheckPrior code paths should only be used for the exact purpose of detecting invalid changes in the return value between successive phases of execution.

Fixes #37807

Target Release

1.13.x, 1.14

Rollback Plan

  • If a change needs to be reverted, we will roll out an update to the code within 7 days.

Changes to Security Controls

Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.

CHANGELOG entry

  • This change is user-facing and I added a changelog entry.
  • This change is not user-facing.

Overview of commits

@jbardin jbardin marked this pull request as ready for review October 24, 2025 14:43
@jbardin jbardin requested a review from a team as a code owner October 24, 2025 14:43
@github-actions
Copy link
Contributor Author

Changelog Warning

Currently this PR would target a v1.14 release. Please add a changelog entry for in the .changes/v1.14 folder, or discuss which release you'd like to target with your reviewer. If you believe this change does not need a changelog entry, please add the 'no-changelog-needed' label.

@jbardin
Copy link
Member

jbardin commented Oct 24, 2025

Holding on merging this for now, since v1.14 is in the RC phase. We can either merge into an rc2 or v1.14.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant