Open
Conversation
Collaborator
|
Please add some tests and should this not be behind a pragma like |
Author
|
Sure. About the extension, there's an open issue about that in the Eta repo right now. I can come back to this PR once that's done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eta uses the
javacalling convention, so I've added it as a token to facilitate parsing of FFI imports/exports. Moreover, the FFI signatures allow class constraints so I changed the parsing offspecto usetruectypeinstead oftruedtype. These changes do indeed work as was tested by runninghlint(which depends on this) on Eta programs that were FFI heavy.