Skip to content

Conversation

philderbeast
Copy link
Collaborator

@philderbeast philderbeast commented Aug 4, 2025

See #9110. After #11093 merged, I started on suggestions with a two count so that these warnings are no longer ignored and will be picked up by our CI linting.

I stopped short of doing all of these as the suggested is digit and is ASCII changes lead me to another change to reuse isAsciiAlpha and because I'm unsure about when and why base functions should be added to module Distribution.Compat.Prelude.

-- | This module does two things:
--
-- * Acts as a compatibility layer, like @base-compat@.
--
-- * Provides commonly used imports.
module Distribution.Compat.Prelude

, isDigit
, isUpper
, isAlpha
, isAlphaNum

I also removed isNum, using isDigit instead in module Distribution.Client.VCS.

Each applied suggestion is an individual commit but I'll squash these if this pull request is approved.


  • Patches conform to the coding conventions.
  • Is this a PR that fixes CI? If so, it will need to be backported to older cabal release branches (ask maintainers for directions).

@philderbeast philderbeast changed the title Hlint/is digit is ascii Satisfy HLint suggestions for isDigit and isAscii Aug 4, 2025
@philderbeast philderbeast force-pushed the hlint/is-digit-is-ascii branch from 59c21b3 to 7a04eb7 Compare August 4, 2025 12:29
- Follow hlint suggestion: Use isDigit
- Follow hlint suggestion: Use isAsciiLower
- Follow hlint suggestion: Use isAsciiUpper
@philderbeast philderbeast force-pushed the hlint/is-digit-is-ascii branch from 7a04eb7 to 9260dac Compare August 4, 2025 14:37
@philderbeast philderbeast added the merge me Tell Mergify Bot to merge label Aug 4, 2025
@mergify mergify bot added ready and waiting Mergify is waiting out the cooldown period merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days labels Aug 4, 2025
@mergify mergify bot merged commit f83f91e into haskell:master Aug 6, 2025
55 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge delay passed Applied (usually by Mergify) when PR approved and received no updates for 2 days merge me Tell Mergify Bot to merge ready and waiting Mergify is waiting out the cooldown period
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants