Remove hie-compat
#4613
Remove hie-compat
#4613
Conversation
dschrempf
force-pushed
the
dom/remove-hie-compat
branch
4 times, most recently
from
d330291 to
3c9d053
Compare
dschrempf
requested review from
michaelpj,
0rphee,
soulomoon,
santiweight,
eddiemundo,
ozkutuk,
kokobd,
July541,
wz1000 and
fendor
as code owners
|
Yeah, I think this is a good idea. In principle, I think we'd like to have some kind of compatibility layer library, but in practice I think it's just spread out everywhere. |
|
There is |
dschrempf
force-pushed
the
dom/remove-hie-compat
branch
2 times, most recently
from
b6b5ecb to
ec910c4
Compare
|
Any other opinions? (I don't feel like dragging this along for too long, but maybe there is a way forward?) |
|
I think @wz1000 is most likely to have a real opinion? |
dschrempf
force-pushed
the
dom/remove-hie-compat
branch
4 times, most recently
from
11ab93f to
be8be55
Compare
|
It seems there are no more opinions. I sgguest reviewing/merging or closing this PR. |
|
I think we just need an opinion from @wz1000 |
|
I think we should go ahead and rebase/review/merge or close. |
|
I think this is fine, but we do lose a bit of flexibility by losing the ability to backport fixes and improvements to hie file generation. The format is more stable now, so perhaps that isn't such a big concern and we just require upgrading the ghc version to get access to newer hie file fixes. |
dschrempf
force-pushed
the
dom/remove-hie-compat
branch
from
be8be55 to
990ef2b
Compare
|
Thank you @wz1000 for your opinion. I have rebased the PR. I think it is good to remove unnecessary compability layers. The only concern I have is that on the Hackage page of |
|
Nothing stops us reviving the package and publishing new versions in the future if we need, so let's do this for now. |
|
I am unsure what the two failing checks mean. Let me know, if I can do something about them! @michaelpj |
While removing references to GHC 9.4, I realized that some parts of HLS are referring to even older versions of GHC. For example, `hie-compat` is a compatibility library backporting support of Haskell IDE Engine (HIE) features to older versions of GHC. Since GHC 9.2, `hie-compat` only re-exported definitions already present in the `ghc` library, and so, is essentially obsolete. FYI: We still have `hie-compat` in the dependency graph, because some libraries (e.g., `hiedb`) are using it.
dschrempf
force-pushed
the
dom/remove-hie-compat
branch
from
990ef2b to
1854c11
Compare
After removing support for GHC 9.4, I was in the mood of cleaning up a bit more. While removing references to GHC 9.4, I realized that some parts of HLS are referring to even older versions of GHC.
Now, some people may hate me for that, but: I completely removed the now obsolete
hie-compatlibrary.hie-compatis a compatibility library backporting support of Haskell IDE Engine (HIE) features to older versions of GHC. Since GHC 9.2,hie-compatonly re-exported definitions already present in theghclibrary, and so, is essentially obsolete.FYI: We still have
hie-compatin the dependency graph, because some libraries (e.g.,hiedb) are using it.This may be a bit harsh, but let me know what you think!