Repository navigation
Fix missing C++ standard library includes for newer LLVM toolchains. - #449
Merged
Merged
Conversation
Contributor
Author
|
@mikesinouye PTAL |
Collaborator
|
/gcbrun |
allight
force-pushed
the
update-llvm
branch
from
September 19, 2026 01:38
e6988b2 to
0e2a5f1
Compare
Contributor
Author
|
Oh Sorry @mikesinouye I think I killed the /gcbrun by fixing a lint error 🤦 |
Collaborator
|
/gcbrun |
mikex-oss
approved these changes
Sep 19, 2026
Collaborator
|
Just checking, does the lockfile not need to be updated? |
- Update `dependency_support/at_clifford_yosys/yosys.patch` to explicitly include `<stdlib.h>` in `libs/subcircuit/subcircuit.cc` (for `free()`) and `libs/ezsat/ezsat.h` (for `abort()`). - Add `bazel_dep(name = "rules_cc_autoconf", version = "0.24.0")` in `MODULE.bazel` to pick up the upstream `<iterator>` include fix for `std::back_inserter`. - Patch `rules_bison` via `single_version_override` to include `<cstdlib>` in `src/bazel_runfiles.cc` for `getenv()`. This is motivated by the LLVM toolchain upgrade in XLS where stricter libc++ headers no longer transitively include `<cstdlib>` or `<iterator>`.
allight
force-pushed
the
update-llvm
branch
from
September 19, 2026 05:25
0e2a5f1 to
e48deb8
Compare
Contributor
Author
|
Done. Whoops was mostly building this from outside of the project so forgot that wouldn't update the lockfile. |
Collaborator
|
/gcbrun |
mikex-oss
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dependency_support/at_clifford_yosys/yosys.patchto explicitly include<stdlib.h>inlibs/subcircuit/subcircuit.cc(forfree()) andlibs/ezsat/ezsat.h(forabort()).bazel_dep(name = "rules_cc_autoconf", version = "0.24.0")inMODULE.bazelto pick up the upstream<iterator>include fix forstd::back_inserter.rules_bisonviasingle_version_overrideto include<cstdlib>insrc/bazel_runfiles.ccforgetenv().This is motivated by the LLVM toolchain upgrade in XLS where stricter libc++ headers no longer transitively include
<cstdlib>or<iterator>.Change generated using Google Antigravity