Repository navigation
Improvements to Verilator, Cocotb, macros - #452
Open
mczyz-antmicro wants to merge 20 commits into
Open
mczyz-antmicro wants to merge 20 commits into
mczyz-antmicro wants to merge 20 commits into
Conversation
Signed-off-by: Wiktoria Kuna <wkuna@antmicro.com>
Signed-off-by: Michal Czyz <mczyz@antmicro.com>
Signed-off-by: Pawel Czarnecki <pczarnecki@antmicro.com>
Signed-off-by: Michal Czyz <mczyz@antmicro.com>
Internal-tag: [#105127] Signed-off-by: Maciej Kurc <mkurc@antmicro.com>
Signed-off-by: Michal Czyz <mczyz@antmicro.com>
Signed-off-by: Michal Czyz <mczyz@antmicro.com>
Signed-off-by: Michal Czyz <mczyz@antmicro.com>
Signed-off-by: Michal Czyz <mczyz@antmicro.com>
Signed-off-by: Michal Czyz <mczyz@antmicro.com>
Signed-off-by: Michal Czyz <mczyz@antmicro.com>
Signed-off-by: Michal Czyz <mczyz@antmicro.com>
mczyz-antmicro
marked this pull request as ready for review
October 19, 2026 16:17
|
/gcbrun |
Contributor
Author
|
@mikesinouye would be grateful if you could take a look |
mikesinouye
requested changes
Oct 20, 2026
…ions Otherwise, CppCompileActionTemplate compiles unchanged files likely because sources and headers came from two tree artifacts.
Signed-off-by: Michal Czyz <mczyz@antmicro.com>
Signed-off-by: Michal Czyz <mczyz@antmicro.com>
Signed-off-by: Michal Czyz <mczyz@antmicro.com>
Signed-off-by: Michal Czyz <mczyz@antmicro.com>
mczyz-antmicro
force-pushed
the
upstream-verilator-fixes
branch
from
October 23, 2026 10:04
60f5a7e to
ebf419f
Compare
Collaborator
|
/gcbrun |
mikesinouye
requested changes
Oct 23, 2026
mikesinouye
left a comment
mikesinouye
left a comment
Collaborator
There was a problem hiding this comment.
After these are addressed I'll merge the rest looks good
| bazel_dep(name = "openroad", repo_name = "org_theopenroadproject") | ||
| bazel_dep(name = "openroad", version = "0.0.0", repo_name = "org_theopenroadproject") | ||
| bazel_dep(name = "rules_foreign_cc", version = "0.16.0") | ||
| bazel_dep(name = "z3", version = "5.3.1") |
Collaborator
There was a problem hiding this comment.
Does this version actually exist? I can only see 4.15.2 https://registry.bazel.build/modules/z3/4.15.2/overview
Also is there any way to avoid the git_override()? Won't all downstream users of rules_hdl have to start setting that manually
| cocotb_files, | ||
| "/site-packages/cocotb/libs/{}".format(library), | ||
| ) | ||
| for library in ["libcocotbvpi_verilator.so", "libgpi.so"] |
Collaborator
There was a problem hiding this comment.
Less concerning, but how feasible is it to avoid the use of pre-builts here?
| int result = std::system(cmd.c_str()); | ||
| if (result != 0) { | ||
| return result; | ||
| return WEXITSTATUS(result); |
Collaborator
There was a problem hiding this comment.
Windows is already supported in this file, so I'd prefer to avoid breaking it, could you add a small macro check here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed:
sim_genrulesanduvm_genruleswhich facilitate creating test suitesEDIT: removed yosys bump from the scope