Skip to content

nextpnr: move git clone into earlier build stage #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2021
Merged

nextpnr: move git clone into earlier build stage #13

merged 1 commit into from
Jan 17, 2021

Conversation

se-bi
Copy link
Contributor

@se-bi se-bi commented Jan 17, 2021 •
edited
Loading

Hey,
as discussed in #4.

We can split this into as many PRs as you wish.

Indeed better, to not do it in a big blob.

eine
eine requested changes Jan 17, 2021
View reviewed changes
Copy link
Collaborator

@eine eine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the header line. Otherwise, LGTM.

@eine eine added the enhancement New feature or request label Jan 17, 2021
@se-bi se-bi force-pushed the update/nextpnr-stages-git branch from 5595fb4 to 6709f2a Compare January 17, 2021 20:25
@eine eine merged commit 100b94c into hdl:main Jan 17, 2021
@eine
Copy link
Collaborator

eine commented Jan 17, 2021

Nice!

@se-bi se-bi mentioned this pull request Jan 17, 2021
Merged
@se-bi se-bi deleted the update/nextpnr-stages-git branch January 17, 2021 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eine eine eine requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@se-bi @eine