-
Couldn't load subscription status.
- Fork 204
Enable use of xdg-desktop-portal on linux flatpak builds #1437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I've tried this before and it didn't work on the Steam Deck in gaming mode. Have you tested it there? |
|
Installation in gaming mode doesn't work neither before nor after this. You still need to complete the installation in desktop mode, as per recommendations However, instead of flatout crashing, the installer returns a message: This is unrelated to the crash described by the people in the issue I previously linked, btw. |
I'm aware, but I remember NFD portal not even working even when booting into Desktop mode first. We need to verify that. |
|
It works on my steam deck, but people are welcome to test, obviously. |
|
Alright, guess I'll have to re-check then. Are there any possible downgrades concerning these?
|
All of those seem to work fine on my end.
|
|
Thanks, I guess we should get someone in a different DE (e.g. Gnome) to check if it's not too much trouble. I'm using KDE too so I probably won't see much of a difference. I think as an addendum to this PR, we should probably take the chance to display a friendlier error message considering this won't crash unlike what GTK is currently doing if desktop mode isn't run first. We could probably display a message like this instead: %s being the error message from NFD. We'll need to localize this so we need to finalize this string first before calling the rest for localization, so feel free to suggest a variation. |

This commit enables the use of the portal API for flatpak builds on linux: https://docs.flatpak.org/en/latest/portal-api-reference.html
Specifically for Unleashed Recompiled, this makes the installer use the native file dialog instead of the default gtk one.
As a collateral, this should fix #553, as the file dialog will avoid using the gtk library altogether, on Plasma. I need the affected people to try this fix, however, as I am not able to reproduce the original bug consistently.